Skip to content

Refactor JS type manifest visitors #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2024
Merged

Refactor JS type manifest visitors #286

merged 1 commit into from
Nov 4, 2024
+32 −39

Conversation

@lorisleiva
Copy link
Member

@lorisleiva lorisleiva commented Nov 4, 2024 •
edited
Loading

This PR applies a small refactoring to the JavaScript getTypeManifestVisitors that enables them to use the same instead of the visitor.

@changeset-bot
Copy link

changeset-bot bot commented Nov 4, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: fe72845

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

This was referenced Nov 4, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@lorisleiva Graphite App
Copy link
Member Author

lorisleiva commented Nov 4, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @lorisleiva and the rest of your teammates on Graphite Graphite

@lorisleiva lorisleiva mentioned this pull request Nov 4, 2024
Merged
@lorisleiva lorisleiva force-pushed the loris/allow-nesting-stacks branch from 4bda806 to 2cb9364 Compare November 4, 2024 11:12
@lorisleiva lorisleiva force-pushed the loris/refactor-js-type-manifests branch from ed8e76e to 1182671 Compare November 4, 2024 11:12
@lorisleiva lorisleiva mentioned this pull request Nov 4, 2024
Merged
@lorisleiva lorisleiva marked this pull request as ready for review November 4, 2024 12:21
@lorisleiva Graphite App
Copy link
Member Author

lorisleiva commented Nov 4, 2024 •
edited
Loading

Merge activity

  • Nov 4, 8:46 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Nov 4, 9:21 AM EST: Graphite rebased this pull request as part of a merge.
  • Nov 4, 9:22 AM EST: A user merged this pull request with Graphite.

@lorisleiva lorisleiva changed the base branch from loris/allow-nesting-stacks to graphite-base/286 November 4, 2024 14:17
@lorisleiva lorisleiva changed the base branch from graphite-base/286 to main November 4, 2024 14:19
@lorisleiva lorisleiva force-pushed the loris/refactor-js-type-manifests branch from 1182671 to fe72845 Compare November 4, 2024 14:20
@lorisleiva lorisleiva merged commit 274af2e into main Nov 4, 2024
2 checks passed
@lorisleiva lorisleiva deleted the loris/refactor-js-type-manifests branch November 4, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lorisleiva